KD tree bug - again

Feature requests, bug reports and related discussion
User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

KD tree bug - again

Post by fused » Sun Mar 29, 2009 9:07 am

with version 1.1.18 x64.

BVH is ok, kd tree misses lots of intersections :)

(also, there are quite a few fireflies and the longer i render the more fireflies turn up. weird, because i only used diffuse materials. pathtracing without bidir)
Attachments
scene.zip
scene
(1.65 MiB) Downloaded 188 times
kd.jpg
KD
kd.jpg (69.92 KiB) Viewed 4176 times
bvh.jpg
BVH
bvh.jpg (50.63 KiB) Viewed 4176 times

User avatar
Kram1032
Posts: 6649
Joined: Tue Jan 23, 2007 3:55 am
Location: Austria near Vienna

Post by Kram1032 » Sun Mar 29, 2009 10:41 pm

at least, they don't turn black anymore... xD

User avatar
PureSpider
Posts: 1459
Joined: Tue Apr 08, 2008 9:37 am
Location: Karlsruhe, BW, Germany
Contact:

Post by PureSpider » Tue Mar 31, 2009 4:35 am

They just turned black cause not much light got inside the poly-holes... Same issue as far as I see it :?

User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

Post by fused » Tue Mar 31, 2009 8:52 am

Did some testing on the firefly issue.
All renders are with linear tonemapping.

---------------------------------------------------------------------------------------
Blackbody emitters, PT.
Image
---------------------------------------------------------------------------------------
Blackbody emitters, bidir PT.
Image
---------------------------------------------------------------------------------------
Blackbody emitters, MLT.
Image
---------------------------------------------------------------------------------------
Blackbody emitters, bidir MLT. note how different it looks compared to the other blackbody versions.
Image
---------------------------------------------------------------------------------------
Sun, MLT.
Image
---------------------------------------------------------------------------------------
Sun, PT.
Image
---------------------------------------------------------------------------------------
RGB emitters, PT.
Image
---------------------------------------------------------------------------------------
RGB emitters, MLT.
Emitters are scalted by the factor 5 this time. Fireflies disappear.
Image
---------------------------------------------------------------------------------------
RGB emitters, PT.
Emitters are scalted by the factor 5 this time. Fireflies disappear.
Image

User avatar
Kram1032
Posts: 6649
Joined: Tue Jan 23, 2007 3:55 am
Location: Austria near Vienna

Post by Kram1032 » Wed Apr 01, 2009 1:44 am

very nice test :)
So, the kd-problem is solved? Or are they all with bvh?

User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

Post by fused » Wed Apr 01, 2009 3:07 am

:)
all with bhv, kd is still borked.

but ono said that hell fix the firefly issue.

User avatar
SATtva_
1st Place Winner
Posts: 179
Joined: Sat Sep 27, 2008 6:44 am
Location: Russia, Siberia
Contact:

Post by SATtva_ » Wed Apr 01, 2009 3:14 am

I hope you meant "he'll". :)

User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

Post by fused » Wed Apr 01, 2009 3:17 am

;)


:twisted:
Last edited by fused on Wed Apr 01, 2009 3:17 am, edited 1 time in total.

User avatar
CTZn
Posts: 7240
Joined: Thu Nov 16, 2006 4:34 pm
Location: Paris, France

Post by CTZn » Wed Apr 01, 2009 3:17 am

Everyone wants chaos to be under control, that's insane :mrgreen:

Damnit, PT is PT... or is it really "broken" ? Though, any fix is a good thing.

User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

Post by fused » Wed Apr 01, 2009 3:18 am

CTZn wrote:Damnit, PT is PT... or is it really "broken" ? Though, any fix is a good thing.
well, obviously its not working correctly when using small emitters. "broken" is probably different

User avatar
CTZn
Posts: 7240
Joined: Thu Nov 16, 2006 4:34 pm
Location: Paris, France

Post by CTZn » Wed Apr 01, 2009 3:29 am

I don't see this as being incorrect, just unwanted :)

It would need an expert to confirm or infirm my says, but I believe that simple PT is archaic and that fireflies are the normal result of that stochastic(=random?) process wich uses no guides (optimisations) afaik. So reducing or removing fireflies would change the nature of pt to something different, that's my belief. I'm wondering if the request is sane, really.

When I want to reduce path tracing limitations to a maximum, I use plain MLT :D Well bidir does a great job too isn't it ?

User avatar
Kram1032
Posts: 6649
Joined: Tue Jan 23, 2007 3:55 am
Location: Austria near Vienna

Post by Kram1032 » Wed Apr 01, 2009 4:28 am

tiny light-sources often make problems...
As it's rendering from Camera to Lightsource (to avoid dead rays), Indigo needs to randomly find a lightsource. A big emitting area allows faster convergance, as it's more likely to be found.
That's also, why Indigo with more lightsources rather gets more efficient than less. - the more direct light, the less indirect one :)

User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

Post by fused » Wed Apr 01, 2009 4:54 am

Kram1032 wrote:tiny light-sources often make problems...
As it's rendering from Camera to Lightsource (to avoid dead rays), Indigo needs to randomly find a lightsource. A big emitting area allows faster convergance, as it's more likely to be found.
That's also, why Indigo with more lightsources rather gets more efficient than less. - the more direct light, the less indirect one :)
yep accepted and confirmed :)
CTZn wrote:I don't see this as being incorrect, just unwanted :)

It would need an expert to confirm or infirm my says, but I believe that simple PT is archaic and that fireflies are the normal result of that stochastic(=random?) process wich uses no guides (optimisations) afaik. So reducing or removing fireflies would change the nature of pt to something different, that's my belief. I'm wondering if the request is sane, really.

When I want to reduce path tracing limitations to a maximum, I use plain MLT :D Well bidir does a great job too isn't it ?
sorry ctz, but this doesnt sound logical for me. also, you know ono and how he is having and eye on staying as physically correct as possible. i guess if this was a usual limitation of PT he wouldn't have said that i can and will be fixed?

regarding plain MLT: take a closer look, it has fireflies, too!

User avatar
CTZn
Posts: 7240
Joined: Thu Nov 16, 2006 4:34 pm
Location: Paris, France

Post by CTZn » Wed Apr 01, 2009 9:05 am

Well, my logic beneath is that having fireflies in a render does not mean it's biased. If you have 3 fireflies on an image that means 3 unwanted samples amongst thousands, as you know. That is acceptable for me, furthermore because supersampling gets rid of ff like a charm.

Again I'm not an expert, I'm exposing own beliefs more than arguing and I would like to know more on that topic (are ff inherent to pt ?) :)

edit: on the MLT render with ff: is that reproducible ?

User avatar
fused
Developer
Posts: 3648
Joined: Fri Sep 22, 2006 7:19 am
Location: Berlin, Germany
3D Software: Cinema 4D

Post by fused » Wed Apr 01, 2009 9:21 am

download the scene and try it :)

the longer you render the more fireflies turn up and won't go away. this is definitely an issue ;)

Post Reply
24 posts

Who is online

Users browsing this forum: No registered users and 3 guests