my first patch

A forum for exporter development discussion.
Post Reply
8 posts • Page 1 of 1
User avatar
dougal2
Developer
Posts: 2532
Joined: Wed Nov 15, 2006 8:17 am
Location: South London

my first patch

Post by dougal2 » Tue Apr 24, 2007 3:34 am

1. contains a few little mods to make it compile under Dev-C++ 4.9.9.2.
* there were two (float) typecasts I think, and another (std::string) typecast.
* needed to change _asm syntax for dev-c++.

2. increased precision of PI and LN_2

3. completely changed the widgets layout.

4. removed auto-updating on slider change.

5. Added an "update image" button to apply current settings.

known problems:

1. when compiled with dev-c++ violet crashes on exit. Probably a problem with my setup or wx version or something. I'm assuming that this won't happen if this diff is merged into your own source.
Attachments
violet-dougalpatch1.diff.igs
this is a .diff file. (ascii text)
(12.94 KiB) Downloaded 200 times
violet-dougalpatch1.jpg
violet-dougalpatch1.jpg (55.76 KiB) Viewed 2292 times

User avatar
OnoSendai
Developer
Posts: 6241
Joined: Sat May 20, 2006 6:16 pm
Location: Wellington, NZ
Contact:

Post by OnoSendai » Tue Apr 24, 2007 3:43 am

Awesome :)
I'll have a look thru the patch later.
The layout desperately needed to be fixed, thanks :)

User avatar
manitwo
Posts: 1029
Joined: Wed Jul 05, 2006 4:50 am
Location: Tirol - Austria

Post by manitwo » Tue Apr 24, 2007 3:46 am

very cool dougal! :D

User avatar
SmartDen
Developer
Posts: 999
Joined: Fri Oct 13, 2006 10:58 pm
Location: Canary Islands
Contact:

Post by SmartDen » Tue Apr 24, 2007 3:52 am

Please add "Auto update" checkbox too

User avatar
dougal2
Developer
Posts: 2532
Joined: Wed Nov 15, 2006 8:17 am
Location: South London

Post by dougal2 » Tue Apr 24, 2007 4:06 am

added autoupdate checkbox
Attachments
violet-dougalpatch1a.diff.igs
(13.83 KiB) Downloaded 178 times

User avatar
SmartDen
Developer
Posts: 999
Joined: Fri Oct 13, 2006 10:58 pm
Location: Canary Islands
Contact:

Post by SmartDen » Tue Apr 24, 2007 4:12 am

That was quickly! Thanks
:shock: WTF is "Camera Glare"?! New Feature?

User avatar
OnoSendai
Developer
Posts: 6241
Joined: Sat May 20, 2006 6:16 pm
Location: Wellington, NZ
Contact:

Post by OnoSendai » Tue Apr 24, 2007 4:46 am

Merged patch, it's checked in.

User avatar
OnoSendai
Developer
Posts: 6241
Joined: Sat May 20, 2006 6:16 pm
Location: Wellington, NZ
Contact:

Post by OnoSendai » Tue Apr 24, 2007 4:52 am

I've put up a build in this thread:

http://www2.indigorenderer.com/joomla/f ... 8262#18262

SmartDen: try it out :)

Post Reply
8 posts • Page 1 of 1

Who is online

Users browsing this forum: No registered users and 19 guests